fix: Improve performance of blocks service by dependency injection #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filvecchiato
changed the title
Imod7
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It slightly improves the performance of the blocks controller by injecting the historic api to calculate the fees removing two extra promises per extrinsic.
It improves the single block query by ~15% (tested on large blocks in different chains) and also improves the response time on range queries by ~10%. On large ranges > 200 blocks, the improvement reduces as I believe it becomes more of a memory issue.
We should probably have a discussion on what to do with the range query, since if extrinsics/block will increase, that specific query will become slower, even if performance is further improved.